visjs-community / visjs-network

the network module from vis.js
Apache License 2.0
60 stars 21 forks source link

Setting hoverConnectedEdges to false causes node hover to stop working #64

Closed Tyler-Maclachlan closed 5 years ago

Tyler-Maclachlan commented 5 years ago

Having my interaction options set as

interaction: {
    selectConnectedEdges: false,
    hideEdgesOnDrag: true,
    hover: true
}

lets me hover nodes, but it hovers the edges as well.

Setting it to:

interaction: {
    selectConnectedEdges: false,
    hideEdgesOnDrag: true,
    hover: true,
    hoverConnectedEdges: false
}

Causes node and edge hover to stop.

micahstubbs commented 5 years ago

hi @Tyler-Maclachlan, thanks for reporting this one!

curious, could you share an example that reproduces the bug? if you can make the example by modifying one of the existing examples, that would be most helpful!

https://github.com/visjs-community/visjs-network/tree/master/examples

Tyler-Maclachlan commented 5 years ago

Hi @micahstubbs,

So it seems if I hover the edge and go straight from the edge to the node then the node hover works. If I try hover a node without first hovering a connected edge it does not work.

Here is a link to jsbin using the Basic Usage example: bin

I wasn't 100% sure how to get a cdn for vis-network working.

Tyler-Maclachlan commented 5 years ago

Hi @micahstubbs,

I have submitted a PR that fixes this issue and adds the functionality for #65 that I need.