search

visjs-community / visjs-network

the network module from vis.js
Apache License 2.0
60 stars 21 forks source link

Fix hover node #66

Closed Tyler-Maclachlan closed 5 years ago

Tyler-Maclachlan commented 5 years ago

Fix node hover breaking when hoverConnectedEdges = false

Fix #64

micahstubbs commented 5 years ago

hi @Tyler-Maclachlan thanks for the contribution! could you run these commands to get the integration tests passing?

Once the tests are green, I'll take a look at this one.

cd visjs-network
yarn
yarn format
git add .
git commit -m "yarn format"
git push
Tyler-Maclachlan commented 5 years ago

Hi @micahstubbs, I've run the commands and pushed.

micahstubbs commented 5 years ago

nice, the tests are green!

I'm going to try and test this out with this example https://jsbin.com/voritexeru/edit?html,js,output

from this issue comment https://github.com/visjs-community/visjs-network/issues/64#issuecomment-494665554

does that sound like the best approach to you @Tyler-Maclachlan ?

Tyler-Maclachlan commented 5 years ago

Sounds good to me

Tyler-Maclachlan commented 5 years ago

hi @micahstubbs,

Any kind of timeline on when this can get merged?

micahstubbs commented 5 years ago

@Tyler-Maclachlan hopefully soon 😅

mojoaxel commented 5 years ago

:love_letter: Thanks @Tyler-Maclachlan for your contribution! This pull-request has been merge into https://github.com/visjs/vis-network/pull/28