Hidden edge bug - Githubissues

visjs-community / visjs-network

the network module from vis.js

Apache License 2.0

60 stars 21 forks source link

Hidden edge bug #68

Closed DarylMcCullough closed 5 years ago

DarylMcCullough commented 5 years ago

Fixes issue #67 "Network - does updating an edge cause it to reset automatically in Hierarchical view".

There is an example of the buggy behavior in test/hidden_edge_test.html. To see the bug:

Click on node 3.
Drag it to the right.
Release the mouse.
Then hover over node 3 (or any other node or edge).
The graph will reset (it shouldn't).

The only change is to the file Edge.js in lib/network/modules/components. Rebuild using "yarn" and "yarn build" and then retry the example hidden_edge_test.html

DarylMcCullough commented 5 years ago

Fixed a formatting issue that caused yarn format:check to fail (I don't actually understand what the problem was, something about white space, maybe?)

micahstubbs commented 5 years ago

thanks for the contribution @DarylMcCullough! I hope to test this and get it in sometime over the upcoming July 4th holiday. stay tuned.

micahstubbs commented 5 years ago

ok, testing this out locally at http://127.0.0.1:8080/test/hidden_edge_test.html

here is what I see when I add hidden_edge_test.html to the master branch. I can reproduce the bug. Thanks @DarylMcCullough for the test and the nice instructions to reproduce the bug!

visjs-67-hidden-edge-bug

micahstubbs commented 5 years ago

and here's the fix, testing locally on @DarylMcCullough's branch. works beautifully 👍

visjs-network-67-hidden-edge-fix

mojoaxel commented 5 years ago

:love_letter: Thanks @DarylMcCullough for your contribution! This pull-request has been merge into https://github.com/visjs/vis-network/pull/29