visjs / ngx-vis

An angular 5+ vis.js project
https://visjs.github.io/ngx-vis
MIT License
69 stars 31 forks source link

Performance Optimization #388

Closed hypery2k closed 4 years ago

hypery2k commented 4 years ago

Is your feature request related to a problem? Please describe. Vis Timeline triggers periodically via setTimeout for a rerender. This causes performance issues (as shown by @luchsamapparat):

Untitled_ Jan 22, 2020 11_25 AM

Describe the solution you'd like

Describe alternatives you've considered

Additional context Demo: https://vistimelineexample.z22.web.core.windows.net/ Source: https://github.com/luchsamapparat/vis-timeline-example

Maybe related to #385 and #211

hypery2k commented 4 years ago

@Thomaash Would to show think about dropping the setTimeout here:

https://github.com/visjs/vis-timeline/blob/2861085da96b1d76a8e31d04d87281a83979c0de/lib/timeline/Range.js#L151-L152

Thomaash commented 4 years ago

Timeline is best to be discussed with @yotamberk. My insight into this is limited.

hypery2k commented 4 years ago

Could be verified with Lighthouse CI