search

visjs / vis-network

:dizzy: Display dynamic, automatically organised, customizable network views.
https://visjs.github.io/vis-network/
Apache License 2.0
2.94k stars 362 forks source link

adopt open pull-requests from almende/vis is usefull #43

Open mojoaxel opened 5 years ago

mojoaxel commented 5 years ago

Lets together go through all oben pull request for almende/vis and see what we can selvage :wink:

mojoaxel commented 5 years ago

https://github.com/almende/vis/pull/3846

:question: Looks simple. Adds multible functions to the Network prototype. Not sure why we need this.

mojoaxel commented 5 years ago

https://github.com/almende/vis/pull/3856

:+1: This looks like a useful fix.

mojoaxel commented 5 years ago

https://github.com/almende/vis/pull/3880

:exclamation: :+1: Looks useful, but is missing documentation :-(

mojoaxel commented 5 years ago

https://github.com/almende/vis/pull/3881

:+1: Looks like everything is there. Could be useful to somebody! Maybe needs a test.

mojoaxel commented 5 years ago

https://github.com/almende/vis/pull/4070

:+1: :rocket: This is just an example, but a useful one! We definitely should adopt this!

mojoaxel commented 5 years ago

https://github.com/almende/vis/pull/4159

:+1: Nice speed improvement. Needs only minor adoption.

mojoaxel commented 5 years ago

https://github.com/almende/vis/pull/4172

:+1: Nice new set of images. This would be an improvement, but I think the best way would be to replace these images all together (see #31)

mojoaxel commented 5 years ago

https://github.com/almende/vis/pull/4202

:exclamation: :+1: Look good. Looks like a improvement of the dot language "dir" feature. Docs and an example is missing :disappointed:

mojoaxel commented 5 years ago

https://github.com/almende/vis/pull/4223

:-1: No longer needed. Already fixed.

mojoaxel commented 5 years ago

https://github.com/almende/vis/pull/4229

:+1: Should be merged!

mojoaxel commented 5 years ago

https://github.com/almende/vis/pull/4242

:+1: Should be merged!

mojoaxel commented 5 years ago

https://github.com/almende/vis/pull/4280

:+1: looks useful. Should be checked an merged.

kmalyavina commented 4 years ago

almende/vis#3846

❓ Looks simple. Adds multible functions to the Network prototype. Not sure why we need this.

Ran into this myself when trying to convert what I was working on (basically the Neighborhood Highlighting example but with clusters) from regular JS to TypeScript.

network.updateClusteredNode() exists in the type definition, compiler is happy, but breaks with TypeError: network.updateClusteredNode is not a function when it tries to execute.

If I try network.clustering.updateClusteredNode(), the compiler complains that Property 'clustering' does not exist on type 'Network'.