visjs / vis-timeline

📅 Create a fully customizable, interactive timelines and 2d-graphs with items and ranges.
https://visjs.github.io/vis-timeline/
Other
1.85k stars 311 forks source link

customTime no longer accepts `options` #1764

Open barreeeiroo opened 8 months ago

barreeeiroo commented 8 months ago

I was looking for ways to make my customTime not editable (i.e., so that users won't be dragging that item), and I came up with the following commit:

This commit added the possibility of passing an options object so that {editable: false} would disable this drag-and-drop functionality. However, when using the library, passing this seems to have no effect. And after investigating a bit more, this change was later removed by the following commit:

Not sure if this change was intentional, but it seems like it could have been removed by mistake (no documentation highlights the opposite, and I couldn't find any discussion or issue where this removal was documented).

Are there any concerns on bringing it back?