search

vislab-tecnico-lisboa / vizzy

The tools you need to interact with Vizzy robot.
12 stars 9 forks source link

Kinetic migration #63

Closed joao-avelino closed 7 years ago

joao-avelino commented 7 years ago

Merging kinetic changes with master. They also work in Indigo.

gsaponaro commented 7 years ago

Hi @joao-avelino ! The branch kinetic-migration has been merged into master, therefore kinetic-migration can be probably deleted now. You can do that by going to https://github.com/vislab-tecnico-lisboa/vizzy/pull/63 and clicking 'Delete branch' at the bottom. The advantage is that the repository will be cleaner to maintain, without unneeded branches lying around.

/cc @ruipimentelfigueiredo

joao-borrego commented 7 years ago

I was working on this branch, but it was mostly unorganized. I will branch out from master, organize my commits (simplified urdf model for collision, which results in better performance, fixed issues concerned with the migration to Kinetic and others that I have worked on during the past weeks on model-simplification branch).

gsaponaro commented 7 years ago

Hi @jsbruglie, sure, go ahead in your own branch. In the meantime I have deleted kinetic-migration, which has already been merged. I just spoke with @ruipimentelfigueiredo to confirm that.

In general it's a good practice to delete branches that have already been merged, to avoid keeping defunct branches lying around with no novel content. See https://github.com/blog/1335-tidying-up-after-pull-requests

joao-avelino commented 7 years ago

Hi @gsaponaro! Thanks for taking a look at it and deleting the branch.

ruipimentelfigueiredo commented 7 years ago

Thanks and good job @gsaponaro! You are totally right.