search

vislearn / FrEIA-community

Community-driven effort to improve and extend FrEIA
0 stars 0 forks source link

Unittests #4

Open psteinb opened 3 years ago

psteinb commented 3 years ago

What?

The test coverage is very low. There is no unified way to test e.g. invertibility, or Jacobian (has to be written once, and can work for all modules).

How?

Set up the proper structure to test all modules in a universal way, in addition to module specific tests that may be necessary. Ensure there is test coverage for everything, including FrEIA.framework.ReversibleGraphNet and FrEIA.framework.ReversibleSequential.

psteinb commented 3 years ago

I am happy to help with this one - see also this PR.

With the current setup, the main question is, which CI infrastructure to use. Travis CI is effectively gone for open-source projects. And github actions is the current place to run your scripts. That effectively also means, that all unit tests should be light weight to run on a single CPU.

ardizzone commented 3 years ago

The following issue can be closed once the new tests are done: https://github.com/VLL-HD/FrEIA/issues/45

psteinb commented 3 years ago

Please consider merging VLL-HD/FrEIA#55. It will trigger continuous integration with github actions. This will be the basis for further unit tests to build.

psteinb commented 3 years ago

Thanks @tbung for merging VLL-HD/FrEIA#55. I'd also like your thoughts to the unittest library being used. See VLL-HD/FrEIA#56

ardizzone commented 3 years ago

Hmm, the action appears under the 'Actions' tab, but it's not running. Does anyone have insights?

psteinb commented 3 years ago

Should be triggered by the next PRs coming in that use the workflow code. I'll see to something like this in the afternoon. But feel free to submit a PR and experiment.