search

vislyhq / stretch

High performance flexbox implementation written in rust
https://vislyhq.github.io/stretch/
MIT License
1.98k stars 107 forks source link

refactoring #70

Closed adamnemecek closed 4 years ago

adamnemecek commented 4 years ago

This supersedes https://github.com/vislyhq/stretch/pull/64

adamnemecek commented 4 years ago

I think it might also be a good idea for the project to have a prelude. I can add it.

emilsjolander commented 4 years ago

Looks good! Happy to merge once iOS tests pass

adamnemecek commented 4 years ago

It seems like they are failing because a macOS plan is not setup. Is that something I have to do?

emilsjolander commented 4 years ago

Oh oops. We stopped using circleCI internally so I canceled our macOS plan forgetting it was used here lol. I'll get it sorted

adamnemecek commented 4 years ago

Thx.

adamnemecek commented 4 years ago

Can you merge this? I'd like to add some more things but I dont want to add them to this PR.

emilsjolander commented 4 years ago

@adamnemecek done, thanks!

adamnemecek commented 4 years ago

Thx