search

visma-meglerfront / sweet-modal-vue

The sweetest library to happen to modals.
Other
757 stars 85 forks source link

fixes viewport height issue in Chrome mobile #107

Closed lukastillmann closed 4 years ago

lukastillmann commented 4 years ago

In Chrome Mobile the buttons in the bottom of the modal disappear when the address bar is visible. This is because in Chrome Mobile the address bar is calculated into the viewport height. see also https://stackoverflow.com/questions/52848856/100vh-height-when-address-bar-is-shown-chrome-mobile

This PR fixes the issue by using percentage instead of viewport height to make the modal fullscreen.

Example screenshot without fix:

example without fix

Example screenshot with fix:

example with fix

bluefirex commented 4 years ago

Thanks for your contribution!