search

vispy / jupyter_rfb

Remote Frame Buffer for Jupyter
https://jupyter-rfb.readthedocs.io
MIT License
55 stars 10 forks source link

add dependencies required for tests to contrib docs #60

Closed kushalkolar closed 1 year ago

kushalkolar commented 1 year ago

pillow and simplejpeg are required to run the tests, added to contribution instructions, maybe better to use an install_extras for development?

djhoese commented 1 year ago

In addition to this I wonder if it would be good to define a "tests" extra in the setup.py. Then users could do pip install -e .[tests] and get all hard requirements and those defined for testing? You can see vispy does it here for doc and other things:

https://github.com/vispy/vispy/blob/16d8c5bd8694df9c18086e6fad31ffbaa08abaf4/setup.py#L98-L113

Thoughts?

almarklein commented 1 year ago

In addition to this I wonder if it would be good to define a "tests" extra in the setup.py.

👍 or just [dev]

almarklein commented 1 year ago

Found this open after a few weeks. Let's just merge this. The suggestion still stands as an invitation for anyone to make a PR :)