vispy / jupyter_rfb

Remote Frame Buffer for Jupyter
https://jupyter-rfb.readthedocs.io
MIT License
55 stars 10 forks source link

[FIX] ipywidgets 8.0 upgrade #64

Closed skapin closed 1 year ago

skapin commented 1 year ago
almarklein commented 1 year ago

Does it work for you? Because I get an error and the console says RemoteFrameBufferModel.__super__ is undefined

almarklein commented 1 year ago

The linting job fails, because black has updated, and CI needs updating too. I'll do that in a separate PR, and we can merge main back in once that is merged.

Done. You can now merge/rebase to have a working CI and lint.

skapin commented 1 year ago

Does it work for you? Because I get an error and the console says RemoteFrameBufferModel.__super__ is undefined

I'm waiting for a member on my team to test, i must have missed 1 or 2 things but most of the work is done :)

skapin commented 1 year ago

It's the change on super, I guess it's better now

skapin commented 1 year ago

I think it "should" works in ipywidget 7 too. I didnt have to make breaking change modification.

skapin commented 1 year ago

Ok i will update when it's fully working, tommorow i think

skapin commented 1 year ago

I confirm it's working on my side :)

skapin commented 1 year ago

I added py37. I was a bit strict letting only >=3.8 (3.7 is deprecated this summer, not yet)

djhoese commented 1 year ago

FYI numpy and other scientific python libraries have dropped (or are in the process of dropping) Python 3.8.

almarklein commented 1 year ago

I can confirm that it works on both the latest versions of ipywidgets / lab, as well as on the version that I last updated a year or so ago.

Older versions tests: ipywidgets : 7.6.5 jupyterlab : 3.4.7 notebook : 6.4.7

Latest versions tested: ipywidgets : 8.0.4 jupyterlab : 3.6.1 notebook : 6.5.2

almarklein commented 1 year ago

@djhoese you want to have a look? Otherwise feel free to merge!

djhoese commented 1 year ago

No I won't have time for real testing. Let's merge and see what people think.