vispy / jupyter_rfb

Remote Frame Buffer for Jupyter
https://jupyter-rfb.readthedocs.io
MIT License
55 stars 10 forks source link

Make things work on other notebook implementations #67

Closed almarklein closed 1 year ago

almarklein commented 1 year ago

Closes #53. Might do the same for #57.

I confirmed that this works on VS Code. To this end, I applied two changes:

almarklein commented 1 year ago

RTR @djhoese. The changes to the examples are simply re-rendering with the slightly different snapshot output.

kushalkolar commented 1 year ago

Thanks for trying this out! Doesn't work in collab yet unfortunately, same issue with just the snapshot appearing.

I looked into it a bit and it seems like collab uses a CDN for non-standard widgets? I posted an issue there a while ago to try and get more info. https://github.com/googlecolab/colab-cdn-widget-manager

image

almarklein commented 1 year ago

@kushalkolar I think that its still using an earlier version. I can tell because it says "initial snapshot" - the new version's initial snapshot is simply called "snapshot" :)

almarklein commented 1 year ago

I'm going to merge this now and publish a release.