search

visr / LasIO.jl

Julia package for reading and writing the LAS lidar format.
Other
22 stars 13 forks source link

[WIP] Mutable memory mapping #12

Open evetion opened 6 years ago

evetion commented 6 years ago

On top of #10

codecov-io commented 6 years ago

Codecov Report

Merging #12 into master will increase coverage by 0.3%. The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #12     +/-   ##
=========================================
+ Coverage   62.62%   62.93%   +0.3%     
=========================================
  Files           8        8             
  Lines         396      402      +6     
=========================================
+ Hits          248      253      +5     
- Misses        148      149      +1
Impacted Files Coverage Δ
src/LasIO.jl 100% <ø> (ø) :arrow_up:
src/fileio.jl 45.45% <75%> (-0.7%) :arrow_down:
src/point.jl 67.27% <77.77%> (+3.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0c35f4c...4939d02. Read the comment docs.

visr commented 5 years ago

What shall we do with this? It looks useful to be able to replace points in a memory mapped PointVector.

As far as I see no need to also make LasPoint mutable, other than convenience. I'm worried about performance if we do that. We can always include some convenience functions for updating the classifications for instance. Also packages like https://github.com/jw3126/Setfield.jl make "modifying" immutables less of a hassle.