fix deprecations for 1.0

visr / LasIO.jl

Julia package for reading and writing the LAS lidar format.

Other

22 stars 13 forks source link

fix deprecations for 1.0 #17

Closed noahstier closed 5 years ago

noahstier commented 5 years ago

Fix deprecated use of Nullable{T} by including package Nullables
Fix deprecated use of Base.showall by changing Base.show to show everything (and 10 points maximum)
Fix deprecated use of Base.Dates with "using Dates" (it's still in the standard library but not in Base)
Replace Vector{T}(n) with Vector{T}(undef, n)
handle change from findlast([]) = 0 to findlast([]) = nothing

visr commented 5 years ago

Thanks! I think I'll make a final 0.6 release right now, since master has some bugfixes and features. Then I'll come back to this and drop 0.6 support (I see you kept it now, but going forward that may be easier for developers).

I think it's best to stop using Nullable and switch to Union{Nothing,T}.

noahstier commented 5 years ago

Sounds good. I agree Union{Nothing,T} is the way to go, I just wanted it to work as soon as possible and don't have the time at the moment.

noahstier commented 5 years ago

Most recent commits break compatibility with 0.6