search

visr / LasIO.jl

Julia package for reading and writing the LAS lidar format.
Other
22 stars 13 forks source link

Rename "creation_doy" to "creation_dayofyear" #20

Closed andyferris closed 5 years ago

andyferris commented 5 years ago

I suspect this is a typo, and should be creation_day rather than creation_doy?

visr commented 5 years ago

No this is not a typo, it stands for "day of year".

From the LAS 1.2 spec:

File Creation Day of Year: Day, expressed as an unsigned short, on which this file was created. Day is computed as the Greenwich Mean Time (GMT) day. January 1 is considered day 1.

File Creation Year: The year, expressed as a four digit number, in which the file was created.

Although arguably creation_day would still be a better name.

andyferris commented 5 years ago

Haha, sorry didn’t realise that! creation_dayofyear?

c42f commented 5 years ago

I remember thinking exactly the same thing the first time I came across "doy" though I don't think it was in this library. +1 for changing it to creation_dayofyear.

visr commented 5 years ago

I'm fine with changing it to creation_dayofyear. Can we deprecate the old field name somehow?

andyferris commented 5 years ago

I guess we could via getproperty?

visr commented 5 years ago

Yeah that should work