search

vistalab / PRFmodel

MIT License
13 stars 7 forks source link

Temporal feature3 #67

Closed KimInsub closed 1 year ago

KimInsub commented 2 years ago

1) added temporal processing related files 2) pmStimulus: fixed Y grid 3) pmTemporal: code clean up

garikoitz commented 2 years ago

ok so should I wait for a new PR? I will merge it this weekend

On Fri, Dec 17, 2021 at 12:19 AM Eline R. Kupers @.***> wrote:

I think we already have certain functions in the general "functions" folder! Unless you are organizing the content of this folder we should be careful not making duplicates!

Also, I don't think we need stigliani's entire model library since we only use a couple functions..

— Reply to this email directly, view it on GitHub https://github.com/vistalab/PRFmodel/pull/67#issuecomment-996268564, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCZAVY7UYU7VPUJAW7LJ4TURJXXZANCNFSM5KHOSXQA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

elinekupers commented 2 years ago

Sorry, I thought this was for a different repository Insub and I are also working on! Please disregard my comment!

garikoitz commented 2 years ago

ah! ok :)

Insub, I will look it this weekend

On Fri, Dec 17, 2021 at 12:25 AM Eline R. Kupers @.***> wrote:

Sorry, I thought this was for a different repository Insub and I are also working on! Please disregard my comment!

— Reply to this email directly, view it on GitHub https://github.com/vistalab/PRFmodel/pull/67#issuecomment-996271557, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCZAV36UFCLIZJCWRGSKP3URJYN3ANCNFSM5KHOSXQA . You are receiving this because you commented.Message ID: @.***>

garikoitz commented 1 year ago

this is old now, Insub says to close it, he has newer branches