search

vistaprint / grunt-js-test

Grunt plugin to run client-side, mocha unit tests and generate code coverage reports
10 stars 11 forks source link

Change all tests to only load one iframe at a time #8

Closed davetodd closed 9 years ago

davetodd commented 9 years ago

Running the "all" browser tests is effectively unusable on large test sets because the competing IFrames cause each other to timeout.

The new "all" page isn't very pretty, but it will only load one test at a time and will report the results as a basic pass/fail so that you can drill into each test without having to scroll through a huge page to find the result. I want to add the individual test stats next, but this at least has the functionality working.

Also fixed an issue where phantom crashes because of included stylesheets.

texclayton commented 9 years ago

I'd like to hear more about the phantom crash caused by Mocha stylesheets. What was the behavior? Did it just simply stop running the tests?

davetodd commented 9 years ago

It crashes with this message:

“Warning: PhantomJS exited unexpectedly with exit code -1073741819. Use --force to continue.”

It does not appear to be correlated to a specific test, so if I just run “grunt js-test” it will always crash, but at a different point each time.

From: texclayton [mailto:notifications@github.com] Sent: Friday, October 24, 2014 2:17 PM To: vistaprint/grunt-js-test Cc: David Todd Subject: Re: [grunt-js-test] Change all tests to only load one iframe at a time (#8)

I'd like to hear more about the phantom crash caused by Mocha stylesheets. What was the behavior? Did it just simply stop running the tests?

— Reply to this email directly or view it on GitHubhttps://github.com/vistaprint/grunt-js-test/pull/8#issuecomment-60427700.

texclayton commented 9 years ago

Weird. I haven't see that before. I'm OK with the changes and will merge them now.