visual-framework / vf-core

A (primarily CSS) framework that targets needs of life science websites and services
https://stable.visual-framework.dev/
Apache License 2.0
20 stars 10 forks source link

The links for the VF-tab angular version are not working as expected. #1937

Closed francisco-ebi closed 1 month ago

francisco-ebi commented 1 year ago

Hello, I have discovered a bug with the vf-tabs component. In the Pathogen portal we have this page:

Screenshot 2023-04-14 at 14 54 19

And if the 'ENA result' link is clicked, it doesn't preserve the 'monkeypox' path, as you can see:

Screenshot 2023-04-14 at 14 56 31

In the VF stable site that doesn't happen so I'm assuming there is a clash between how the component updates the url and how Angular handles the routing. Regards

nikiforosk commented 1 year ago

@bhushan-ebi This looks related to #1845

bhushan-ebi commented 2 months ago

With further follow up on this ticket and after discussion with @francisco-ebi , it's observed that this issue doesn't seem to present on the site anymore. #2037 has been created to further create Angular version of VF Tabs where this issue will be revisited.