visual-framework / vf-core

A (primarily CSS) framework that targets needs of life science websites and services
https://stable.visual-framework.dev/
Apache License 2.0
20 stars 10 forks source link

In mobile view, clicking on About leads to a 404 page #1953

Closed stefangutnick closed 3 months ago

stefangutnick commented 1 year ago

The "About" megamenu transforms to a link when the VF site is viewed on mobile.

The link points to a non-existing page:

https://stable.visual-framework.dev/topics

It should instead point to:

https://stable.visual-framework.dev/about/

stefangutnick commented 1 year ago

See this line

https://github.com/visual-framework/vf-core/blob/b2f0e918b7572b385ec32e28a138d52677df992d/tools/vf-component-library/src/site/_includes/layouts/base.njk#L64

bhushan-ebi commented 3 months ago

Changes should be available on dev site (https://latest.visual-framework.dev/) for testing after next deployment. PR - https://github.com/visual-framework/vf-core/pull/2006

sandykadam commented 3 months ago

Tested this url https://latest.visual-framework.dev/topics but it doesn't redirect

bhushan-ebi commented 3 months ago

@sandykadam, /topics is nonexistent and is not the intended link. If you change the viewport to mobile view and then click on 'about' link, it used to go to /topics. Now it's fixed to go to /about.

sandykadam commented 3 months ago

ah ok, got it. Working as expected then good to close this ticket.