search

visual-framework / vf-core

A (primarily CSS) framework that targets needs of life science websites and services
https://stable.visual-framework.dev/
Apache License 2.0
20 stars 10 forks source link

Fix: Vf-dropdown - Not clickable links in Safari #1972

Closed francisco-ebi closed 3 months ago

francisco-ebi commented 9 months ago

Hi all,

@lilim-ebi from ENA discovered a bug for the Vf-dropdown. If you open https://www.covid19dataportal.org/ or https://www.pathogensportal.org/ and try to click a link on one of the dropdown's (like About or Tools), it works in Chrome and Firefox except in Safari. It's related to the keyboard navigation functionality I added in one of the sprints lead by Niki. I added the fix and updated the configuration to reproduce the issue in the VF component library.

netlify[bot] commented 9 months ago

Deploy Preview for tubular-strudel-7ad396 ready!

Name Link
Latest commit 8c1ce40575ba0978d6dda838abfff4db9b4dae0f
Latest deploy log https://app.netlify.com/sites/tubular-strudel-7ad396/deploys/65326f0647476500080b9c91
Deploy Preview https://deploy-preview-1972--tubular-strudel-7ad396.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sandykadam commented 9 months ago

Thanks @francisco-ebi. Can you please also create a bug issue for this and tag this PR, so it will easy for the release process? Also, can you update the changelog file with that ticket?

sandykadam commented 9 months ago

Thanks, @francisco-ebi we will get this added in the next release.

francisco-ebi commented 9 months ago

Thanks @sandykadam :)

renatocjn commented 6 months ago

Just want to register that we are still having trouble with the covid portal.

sandykadam commented 3 months ago

Tested this change on the latest website and working fine with the new change. Good to close this ticket.