search

visual-framework / vf-core

A (primarily CSS) framework that targets needs of life science websites and services
https://stable.visual-framework.dev/
Apache License 2.0
20 stars 10 forks source link

Update the definition of the token for "link colour" in figma #1998

Closed Adedoyinebi closed 4 months ago

Adedoyinebi commented 4 months ago

From the review done there were inconsistencies observed in the definition of link colours and in the naming of the states in figma and HTML. Link colour defined differently #2A57A3 in figma, #3B6fB6 in HTML.

Task

Update the link colour tokens in figma to match with the description and colours in the vf site.

Add focused state for the link to the tokens described in the figma tokens

stefangutnick commented 4 months ago

I have updated the following in figma:

  1. Design token for links, corrected to #3b6fb6 (aka Blue 600)
  2. Updated the link colour tokens to have Hover and Focus as #193f90 (aka Blue 900)
  3. Added a Focus link variant on the Link component
Adedoyinebi commented 4 months ago

@stefangutnick I have reviewed the updates, no issues spotted. Moving this task to done.