visual-framework / vf-core

A (primarily CSS) framework that targets needs of life science websites and services
https://stable.visual-framework.dev/
Apache License 2.0
20 stars 10 forks source link

Update design of the vf-breadcrumbs in figma and on the vf-site #2009

Closed Adedoyinebi closed 2 months ago

Adedoyinebi commented 3 months ago

From the review of the breadcrumbs design during the Intranet project. The Vf-breadcrumbs component's enhancement on desktop are as follows:

Improve the target area for the breadcrumb Increase the spacing after the “>” symbol from 4px to 8px to avoid overlap of touch target areas for small words in the breadcrumb

Task

Adedoyinebi commented 2 months ago

The desktop variants of the vf-breadcrumbs has been updated in figma

@stefangutnick kindly review this update

stefangutnick commented 2 months ago

@Adedoyinebi The padding now appears to be 4+4 px which is correct, looks good

Adedoyinebi commented 2 months ago

Based on the discussion with @bhushan-ebi yesterday, We agreed to use a padding of 8px on the left and right of the of the ">" Chevron for a uniform padding on both ends.

The padding on the top and bottom of each node has also been updated to 8px to achieve a target touch size of 44px for touch based interactions matching AAA accessibility standard on target touch area

Design of the Vf-breadcrumb has been updated in figma based on this.

@stefangutnick please review

Image below showing desired target touch area without overlap on other elements

Image

bhushan-ebi commented 2 months ago

Figma changes are done as per comment above https://github.com/visual-framework/vf-core/issues/2009#issuecomment-2104274387. Dev changes are done as part of parent ticket #1976