ebi-vf1-integration component additions

[dbushell]

In the vf-wp WordPress theme I'm seeing CSS specificity issues with ebi-global.css overriding the friendlier vf-core styles.

Logging those as I notice them in this issue below.

[auto-comment[bot]]

Thank you for raising an issue. We will try and get back to you as soon as possible. Please make sure you have given us as much context as possible.

[dbushell]

Blockquotes

/* ebi-global */
blockquote, blockquote p {
  color: #8a8a8a;
}

.vf-blockquote is getting re-colored.

[dbushell]

Selects

.vf-form__select is getting various conflicts with a raw select style - primarily a defined height is the biggest visual effect. Visible in vf-wp /blog/ sidebar widgets.

[khawkins98]

I made a quick codepen to see how some of these conflict with ebi-global and Bootstrap 3, 4, and Foundation 6: https://codepen.io/khawkins98/pen/eYYWJNO

In short, it's mostly Foundation (and therefore also EBI 1.x) that makes issues.

I think that means that over time some fixes are going to be:

• only for ebi-vf1-integration
• some will be wider fixes that we could either:
  • better "insulate" VF components from inheritance issues
  • make per-framework fix files (this way lies madness?)

[dbushell]

Textarea

.vf-form__textarea border on :focus get changes, unlike text inputs.

[dbushell]

Dividers

.vf-divider is affected by:

hr {
  clear: both;
  max-width: 80rem;
}

[sturobson]

vf1.x has a :visited state that makes links override vf2.x

[khawkins98]

This still active? Or can we close an tackle new things as they come?

[khawkins98]

Going to close this one until someone shouts