visual-framework / vf-wp

WordPress theme and plugins for Visual Framework integration
3 stars 6 forks source link

ENHANCEMENT - Mobile placement of press contact, other boxes #349

Open khawkins98 opened 4 years ago

khawkins98 commented 4 years ago

Noticed this while reading a news post on my phone: https://www.embl.org/news/science/new-insights-into-epigenetic-modifications/

image

It would be better if the "Press contact" box appeared lower on the mobile phone (bottom of post).

There are two "typical" methods to do this:

  1. Add some kind of push/pull source ordering support to make left column show on the bottom on the mobile (this would also move the author info to the bottom)
  2. Add the "press contact" a second time in the HTML, appearing at the bottom. Use CSS to show/hide accordingly, i.e.vf-u-grid--hide-for-small
  3. Or, dodge it for now, and move the "Press contact" to the right

This will probably bubble up into some things for vf-core, but starting the journey here.

sturobson commented 4 years ago
  1. drop the custom class article-left-col to the bottom using:

As there's 'no grid' on mobile we can use display: flex; up to the viewport size the grid kicks in.


@media (max-width: 1023px) {
  .embl-grid {
    display: flex;
    flex-direction: column;
  }
  .article-left-col {
    order: 2;
  } 
}

*notes:* doing this will effect all `embl-grid`s at these viewports - can we create something like `embl__news-article` on the body to hook into?
sturobson commented 4 years ago

asides:

This (image below) looks incredibly busy compared to our 'containerisation' of the rest of the site designs.

Screenshot 2020-06-11 at 10 20 27

sturobson commented 4 years ago

related:

on - https://wwwdev.embl.org/groups/chemical-biology/ - the contact information is on the right.

Should we aim for some consistency betwixt the two too?

Screenshot 2020-06-15 at 09 36 52