Closed LuchoTurtle closed 7 months ago
Oh wow, that's a highly detailed report. Much appreciated. Let me have a look and I'll get back to you. But first, what's the time pressure on them? This weekend me and the entire are offline. So I'll be able to handle it next week if it's not super urgent.
It's not urgent. It works if I'm not debugging (because the debugger doesn't hang on the line), but the tests do not run. If you can see it in the coming week, that'd be cool :)
Btw, do you have some time to meet on discord? It'd be nice to exchange some words just to be in sync in planning.
Sure, we can set up a time and we can have a chat :). Though the PR's I've opened can surely be merged in the order they were created, so I'm not sure what more planning there needs to be π
Just ping me when you happen to have time. Unfortunately I work in a very umpredictable time environment. Usually I'm available online and I can jump in. 20 mins should suffice.
Issues were fixed in separate commit
Hello!
I'm currently migrating a demo app from
flutter-quill
tovisual-editor
(see more context in https://github.com/dwyl/flutter-wysiwyg-editor-tutorial/issues/3) using the branch from the https://github.com/visual-space/visual-editor/pull/237 (I'm basically using my fork of your repo while https://github.com/visual-space/visual-editor/pull/237 is not merged).Bug 1 π
The app builds fine and inclusively works wonderfully on the web. However, in mobile devices, when I tap the editor to enter text, I get the following error:
The error comes from these lines of code:
https://github.com/visual-space/visual-editor/blob/3747d0e2f43cd88b253df766f201ecfc8045fee6/lib/document/controllers/document.controller.dart#L412-L423
I don't know how to solve this issue, though.
queryChild
is invoked when I tap up after the app initializes and I get this error. Because there is no text, thenodePos.node
isnull
and it fails to cast toLineM
. I don't know, however, what I should return if thenodePos.node
is null.Bug 2 π
In addition to this, when first selecting text to cut/copy or paste, I get the following error on:
This happens in these lines of code, apparently.
https://github.com/visual-space/visual-editor/blob/3747d0e2f43cd88b253df766f201ecfc8045fee6/lib/selection/services/selection-handles.service.dart#L132-L149
How do I replicate these issues?
To replicate this issue, you can create a new Flutter project, and have two files on
lib
:main.dart
home_page.dart
And here's the
pubspec.yaml
file.Make sure to run on a real device. I've tested this on different devices and, when running my unit tests, this error pops up as well. This is why I know this is not related to my phone.