visual-space / visual-editor

Rich text editor for Flutter based on Delta format (Quill fork)
MIT License
290 stars 46 forks source link

Selection - Bad positioning of selection toolbar for large selections #55

Closed adrian-moisa closed 9 months ago

adrian-moisa commented 2 years ago

Copy/Paste tooltip doesn't appear after Select All pressing in readOnly = true mode on real device. However it works as expected on iOS simulators. It happens basically because of _keyboardVisible variable. first time it appears after double click to a QuillEditor's empty area, then it appears also by long press on an empty area or even on the text I use flutter_quill v5.0.3

https://user-images.githubusercontent.com/11160141/175376547-04712947-7fd0-488c-959d-effa9f8a90a6.mov

Original https://github.com/singerdmx/flutter-quill/issues/858

After toying a bit more with the emulator I noticed that actually the copy option is there. However it goes offscreen. I guess it needs a condition to reposition differently if the entire doc is selected. Or some extra padding at the bottom could do it. Can't promise a quick fix. I'm still working on the refactoring part. Though I'm slowly moving towards other maintenance tasks since the bulk of the refactor touched most core files.

image

Join us on discord to get implementation advice and help or follow us on YouTube Visual Coding to learn more about the architecture of Visual Editor and other Flutter software architecture advice.