VE Selection is flickering once selecting past the viewport #83
When attempting to extend the selection bellow the viewport using the mouse the selection keeps flickering. This issue seems to be present in the legacy Quill as well. So it's not coming from our refactoring efforts.
VE Selection - Mobile, The soft keyboard is not triggered #127
Currently the mobile/emulator version of the editor do not trigger the software keyboard.The issue is that we seem unable to trigger it. This issue might be caused by the forking from Quill and the subsequent refactoring. I'd try to run the quill codebase, follow the callstack in that codebase and attempt to follow the same callstack in our codebase. There will be many differences in files setup but overall the code logic is the same. Somewhere we are not doing something right.
Software keyboard not enable
VE Selection - Selection is not cleared after selecting a stretch of text #131 CRITICAL
For some reason after selecting some text, the second time when we attempt to select text again one of the anchors gets stuck on the previous position. This issue might be caused by the forking from Quill and the subsequent refactoring. I'd try to run the quill codebase, follow the callstack in that codebase and attempt to follow the same callstack in our codebase. There will be many differences in files setup but overall the code logic is the same. Somewhere we are not doing something right.
At the moment I can't consistently reproduce it. It seems it is working fine now. But it happened quite a lot recently. So as soon as I have indications on how to reproduce I'll update the ticket.
One way to always reproduce this behaviour is to attempt to grab a screen video in Mac after the cursor was placed. Without hitting Escape you will never be able to properly select text. One of the handles always remains stuck. This issue has been happening in all sorts of moments and often enough that is extremely annoying. Most users wont be able to deal with it. Must be fixed.
Could be related to the last pointer position. (not sure).
VE Selection - Text Selection does not work on mobiles #213
Selectin text does not work on mobiles, further research and testing if this is still an issue is required
VE Selection - Review Text Selection Menu and document #214
final TextSelectionControls? textSelectionControls;
--> Is this a better solution than my current demo for text selection menu?
Should we use them to render the attachment???
Different styles for android and iOS
https://ktuusj.medium.com/flutter-custom-selection-toolbar-3acbe7937dd3
_updateSelectionExtentsVisibility in rendererInner -> bridges from Position to Offset
It's nice and easy to use but it's stuck to only one behaviour of placement. Maybe we want to do something else. In that case there's little help from textSelectionControls.
Quill override both iOS and Android when providing the custom controls
VE Selection - Mobile, Selection menu not rendered at all times #124
In the mobile emoulator, it seems that the selection actions don't work properly. This issue might be caused by the forking from Quill and the subsequent refactoring. I'd try to run the quill codebase, follow the callstack in that codebase and attempt to follow the same callstack in our codebase. There will be many differences in files setup but overall the code logic is the same. Somewhere we are not doing something right. At the moment it is rather difficult to trigger the rendering of the actions menu.
Action handles wrongly placed
A related issue is that the handles are not properly placed. After double tapping a word to trigger the selection we can see that the selection handles are rendered in the position of the previous selection. So this hints strongly that we are not passing correctly the latest selection data. It could be that somehow we messed up updating our state store. Once this one is figured I believe the issue described above will be resolved as well.
After selecting some text on mobile/emulator tapping the text again should trigger a menu where the paste option is visible. This enables the user to do copy paste on mobile. The issue is that we seem unable to trigger it. This issue might be caused by the forking from Quill and the subsequent refactoring. I'd try to run the quill codebase, follow the callstack in that codebase and attempt to follow the same callstack in our codebase. There will be many differences in files setup but overall the code logic is the same. Somewhere we are not doing something right.
VE DocTree - Selection is affected when checking a checkbox #212
Tapping an unchecked checkbox, if it’s just one, the selection will go to the first char in the document for a sec and then be moved to the first letter on the checkbox line, which does not make any sense at all, because we want to not change the caret position while checking a checbox, the method from the below screenshot might be the issue, not sure enough tho.
Also, if there are multiple lines with checboxes grouped togheter, when checking one, the caret will go for a sec to the below line, and then to the first char in the selected line again.
When entering on a line with checkbox, the next line will create a checked checkbox, whih is not expected behaviour, it should create an unchecked checbox.
VE Selection - Reconcile selection toolbar and quick menu #170
Allow disabling of selection toolbar. #https://github.com/singerdmx/flutter-quill/pull/972
Disable the selection toolbar when the quick menu is active
Brainstorm of a better solution. Selection toolbar and quick menu should not be mutually exclusive. The copy / paste ops are useful. At the same the extra buttons in the quick menu are useful as well
VE Selection Actions - Mobile, Selection handles and menu go offscreen #126
The selection handles seem to be overlaid on top of the app header and can be seeing going as far as the system bar. I guess we could setup some sort of a clipping area or stack that contains the rendering to the viewport of the editor.
Selection - Selection height is not matching text size #7
The text size selector was introduced right before I forked Quill. It wasn't fully developed to take care of the various aspects of changing text sizes. The selection rectangles should adapt to the height of the text or of the embeds.
VE Selection - Copy pasting checked checkboxes, all checkboxes show as marked
VE Selection - Shift Selecting works very badly PERF, Bad UI
VE Selection is flickering once selecting past the viewport #83
When attempting to extend the selection bellow the viewport using the mouse the selection keeps flickering. This issue seems to be present in the legacy Quill as well. So it's not coming from our refactoring efforts.
https://user-images.githubusercontent.com/11160141/180625788-623fe875-f9c2-4197-959a-47a4c054daf4.mov
VE Selection - Mobile, The soft keyboard is not triggered #127
Currently the mobile/emulator version of the editor do not trigger the software keyboard.The issue is that we seem unable to trigger it. This issue might be caused by the forking from Quill and the subsequent refactoring. I'd try to run the quill codebase, follow the callstack in that codebase and attempt to follow the same callstack in our codebase. There will be many differences in files setup but overall the code logic is the same. Somewhere we are not doing something right.
Software keyboard not enable
VE Selection - Selection is not cleared after selecting a stretch of text #131 CRITICAL
For some reason after selecting some text, the second time when we attempt to select text again one of the anchors gets stuck on the previous position. This issue might be caused by the forking from Quill and the subsequent refactoring. I'd try to run the quill codebase, follow the callstack in that codebase and attempt to follow the same callstack in our codebase. There will be many differences in files setup but overall the code logic is the same. Somewhere we are not doing something right.
At the moment I can't consistently reproduce it. It seems it is working fine now. But it happened quite a lot recently. So as soon as I have indications on how to reproduce I'll update the ticket.
One way to always reproduce this behaviour is to attempt to grab a screen video in Mac after the cursor was placed. Without hitting Escape you will never be able to properly select text. One of the handles always remains stuck. This issue has been happening in all sorts of moments and often enough that is extremely annoying. Most users wont be able to deal with it. Must be fixed.
Could be related to the last pointer position. (not sure).
https://user-images.githubusercontent.com/11160141/200126231-d8baa4ca-9787-4574-bf35-ea84490c715c.mov
VE Selection - Text Selection does not work on mobiles #213
Selectin text does not work on mobiles, further research and testing if this is still an issue is required
VE Selection - Review Text Selection Menu and document #214
final TextSelectionControls? textSelectionControls; --> Is this a better solution than my current demo for text selection menu?
VE Selection - Mobile, Selection menu not rendered at all times #124
In the mobile emoulator, it seems that the selection actions don't work properly. This issue might be caused by the forking from Quill and the subsequent refactoring. I'd try to run the quill codebase, follow the callstack in that codebase and attempt to follow the same callstack in our codebase. There will be many differences in files setup but overall the code logic is the same. Somewhere we are not doing something right. At the moment it is rather difficult to trigger the rendering of the actions menu.
Action handles wrongly placed A related issue is that the handles are not properly placed. After double tapping a word to trigger the selection we can see that the selection handles are rendered in the position of the previous selection. So this hints strongly that we are not passing correctly the latest selection data. It could be that somehow we messed up updating our state store. Once this one is figured I believe the issue described above will be resolved as well.
After selecting some text on mobile/emulator tapping the text again should trigger a menu where the paste option is visible. This enables the user to do copy paste on mobile. The issue is that we seem unable to trigger it. This issue might be caused by the forking from Quill and the subsequent refactoring. I'd try to run the quill codebase, follow the callstack in that codebase and attempt to follow the same callstack in our codebase. There will be many differences in files setup but overall the code logic is the same. Somewhere we are not doing something right.
VE DocTree - Selection is affected when checking a checkbox #212
VE Selection - Reconcile selection toolbar and quick menu #170
Allow disabling of selection toolbar. #https://github.com/singerdmx/flutter-quill/pull/972 Disable the selection toolbar when the quick menu is active Brainstorm of a better solution. Selection toolbar and quick menu should not be mutually exclusive. The copy / paste ops are useful. At the same the extra buttons in the quick menu are useful as well
VE Selection Actions - Mobile, Selection handles and menu go offscreen #126
The selection handles seem to be overlaid on top of the app header and can be seeing going as far as the system bar. I guess we could setup some sort of a clipping area or stack that contains the rendering to the viewport of the editor.
https://user-images.githubusercontent.com/11160141/193268358-44b7d8fe-459c-476e-ac23-4ba41c0647e7.mov
Selection - Selection height is not matching text size #7
The text size selector was introduced right before I forked Quill. It wasn't fully developed to take care of the various aspects of changing text sizes. The selection rectangles should adapt to the height of the text or of the embeds.
VE Selection - Copy pasting checked checkboxes, all checkboxes show as marked
VE Selection - Shift Selecting works very badly PERF, Bad UI