visualboyadvance-m / visualboyadvance-m

The continuing development of the legendary VBA gameboy advance emulator.
https://visualboyadvance-m.org
3.32k stars 318 forks source link

Real-Time Clock Won't Work #211

Closed Grip555 closed 1 year ago

Grip555 commented 6 years ago

Expected behavior

Real-Time Clock should reflect the time of day it is in real life, in GBA games

Actual behavior

The game is just the default time (12PM).

ROM details

Pokémon FireRed 1.0 Rom Hack (Pokémon Adventures Red Kanto 2F) Save: https://drive.google.com/open?id=1q1ciUXGe9dHW6zgHtPr-0n_kYGjdadIr

Which games are affected by the issue: GBA

Video driver: Open GL

Sound driver: XAudio2

Build: 2.1.0

Operating System: Windows 10

Version of code: Master

Hardware details: 16GB RAM GeForce GTX 1070 3.50 GHz

Grip555 commented 6 years ago

Seriously? Is Real-Time Clock just broken forever now?

ZachBacon commented 6 years ago

Can you just calm down? At most there's just two of us working on vba-m and a lot of the time in our spare time. My day job takes 90% of my personal time leaving the 10% to rest.

Grip555 commented 6 years ago

OK, sorry, just that older version of this emulator had it work and I thought everyone was ignoring this.

ZachBacon commented 6 years ago

No one was ignoring this, but we do have limited time and just two people working in this when they can

eden881 commented 6 years ago

I'm not a contributor to VBA-M, but as a user I can confirm that that in release 2.0.2 the real time clock works well in this exact game - I actually play it in my spare time :smile:

Grip555 commented 6 years ago

Except that version has audio bugs.

ghost commented 6 years ago

without detailing and reporting what the bugs are, it will never get noticed and probably wont ever get fixed

anyways, RTC should be working in latest commit.

Grip555 commented 6 years ago

It's still not working though.

ghost commented 6 years ago

real-time clock should be working fine. to avoid desyncs, keep Real time clock checked always under Game Boy Advance pull down menu.

It may also be possible you are looking at gameplay time found during saving since i dont see where real-time can be seen ingame.

1122112211

Grip555 commented 6 years ago

I mean real time, not in-game time. So like the time of day changes brightness depending on the time it is where you live.

Tried latest version, but it's still not recognizing my computer's clock.

ghost commented 6 years ago

From what i have read about Pokemon Emerald, theres no difference between Day and Night i the game (starting game with time set to 12AM midnight in mgba does not turn sorroundings dark for example like Boktai does), BUT there are places where time does affect it. Ive read the low/high tide in Shoal cove is one, or eeves evolution.

If you can send save file, or better save state of these areas thats suppose to be affected by time please attach them so we can test. (no offense, i really dont like pokemon games)

On Sun, Jul 8, 2018 at 4:32 AM, Grip555 notifications@github.com wrote:

I mean real time, not in-game time. So like the time of day changes brightness depending on the time it is where you live.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/visualboyadvance-m/visualboyadvance-m/issues/211#issuecomment-403241298, or mute the thread https://github.com/notifications/unsubscribe-auth/AWPDtrqCfanNPLqgDI4ox8GTPBDXrvWjks5uERrsgaJpZM4S56Ta .

ghost commented 6 years ago

In addition, to be honest dont really know how this game works.. but there is a clock at the beginning of the game that you need to manually adjust... so is that suppose to be automatic? coz it doesnt seem to be.

TEST BASED ON INGAME'S WALL CLOCK THINGIE:

Test 1.

Test 2:

So my analysis is that the ingame time counter (not necessarily real clock timer or real time) is working. The in-game's clock is based on what time you set this wall clock at the beginning of the game and not an actual representation of real world clock (unless you set this correctly i guess)

In Boktai the ingame clock and day night transition is based on real time clock.

Let me know if I am missing something...

Grip555 commented 6 years ago

I mostly play ROM hacks and they say the time on the pause menu.

ghost commented 6 years ago

you should:

  1. retest using latest version of vbam 2.1.0
  2. if you still have issues, re-edit your 1st post and complete details (like i ddnt even know you are using some sort of hack). the purpose of the template is that we can have an idea of how to replicated the issue. save file + sate state should help too.
Grip555 commented 6 years ago

OK, updated the first post.

ghost commented 6 years ago

do not post rom links...

anyways what is this? you posted about Pokemon Emerald but this game is Pocket Monster Fire Red, which does not even support real-time clock...

Grip555 commented 6 years ago

Oh sorry.

It's a ROM hack that adds support for time and you can see what time it is by opening the menu.

pokemon adventure red kanto complete 2f_01

pokemon adventure red kanto complete 2f01

First one is what it should show, second is what it shows with the latest version of VBA-M

ghost commented 6 years ago

this is unofficially supported, cant even confirm what the rom hack's actual name is and who made it. the rom doesnt even have the correct identfication... let me see if i can create something unofficially......

ghost commented 6 years ago

ok, it looks like you can just use the Game Overrides option for this...

screenshot_2018-07-09_22-30-04

Grip555 commented 6 years ago

Wow, thanks!

GlacyAnime commented 3 years ago

BOI THANKS IT WORKED LIKE I WANTED. I AM PLAYING POKRMON UNBOUND. THANKS DUDEEEE

mrobert09 commented 1 year ago

Hate to possibly reopen this and beat a dead horse, but the Real Time Clock feature isn't working for me in version 2.1.4 or 2.1.1. Options -> Game Boy Advance -> Real-time clock is checked, and once the ROM is loaded the settings in Game Overrides are exactly as ghost's screenshot are.

ROM being run: Pokemon Unbound (v2.1.1.1)

Worth noting, the old VBA file I have (Visual Boy Advance 1.8.0 Beta3) from Emulator Zone works just fine with the RTC setting. So I'm at a loss for why VBA-m 2.1.1 or 2.1.4 are not functioning for me.

ZachBacon commented 1 year ago

Firstly, try a nightly from http://nightly.vba-m.com and report back. But make sure it's a clean config just to be on the safe side.

mrobert09 commented 1 year ago

I tried the nightly release and still not working. Not sure how to do a "clean config" (not sure where the config settings are stored). I did put the file in a fresh folder and ran it from there, though.

Screenshots: Capture1 Capture2

Felipefpl commented 1 year ago

(not sure where the config settings are stored)

Configs are in the worst place of all, users-computer name-appdata-local folder. :P - it'd be MUCH better if it was stored in the emu's folder like other emus do, obviously the devs have a good reason to do this ;) but i hope this changes in the future.

mrobert09 commented 1 year ago

K just tried it with a fresh config and still the same issue. Capture3

ZachBacon commented 1 year ago

(not sure where the config settings are stored)

Configs are in the worst place of all, users-computer name-appdata-local folder. :P - it'd be MUCH better if it was stored in the emu's folder like other emus do, obviously the devs have a good reason to do this ;) but i hope this changes in the future.

We support both methods, both applocaldata and in the emu's folder. To have it default to emu folder just create a blank vbam.ini by the exe and it uses that instead.

Felipefpl commented 1 year ago

(not sure where the config settings are stored)

Configs are in the worst place of all, users-computer name-appdata-local folder. :P - it'd be MUCH better if it was stored in the emu's folder like other emus do, obviously the devs have a good reason to do this ;) but i hope this changes in the future.

We support both methods, both applocaldata and in the emu's folder. To have it default to emu folder just create a blank vbam.ini by the exe and it uses that instead.

@ZachBacon - Nice, thanks for the info

Squall-Leonhart commented 1 year ago

Pokemon Unbound users must refer to https://github.com/visualboyadvance-m/visualboyadvance-m/issues/324

it would also be nice if Pokemon Unbound devs added the RTC patch so that the emulator enables RTC automatically.