search

visualfabriq / bquery

A query and aggregation framework for Bcolz (W2013-01)
https://www.visualfabriq.com
BSD 3-Clause "New" or "Revised" License
56 stars 11 forks source link

initial bquery files #1

Closed FrancescElies closed 9 years ago

FrancescElies commented 9 years ago

Hi Carst,

I isolated some files and they it can be compiled with python setup.py build_ext --inplace, do you think we could use this as our initial setup?

Files Based on https://github.com/Blosc/bcolz

Regards, Francesc

CarstVaartjes commented 9 years ago

Looks great! Also needs a dependency on bcolz added I think. You can merge the pull request yourself right? (in terms of rights?)

CarstVaartjes commented 9 years ago

Ah, also we need the ctable additions (the groupby etc. stuff), it's not in there yet I think?

FrancescElies commented 9 years ago

About the PR I can merge it myself, rights are :ok_hand: I wanted to get some practice too with this way of doing things. Groupby stuff is missing, you are right, this was only a initial building proof of concept :) (I did not really check if something)

Now I have a couple of minutes free I'll have a loo if it's not very complicated.

CarstVaartjes commented 9 years ago

I think it's not that bad, only you need to import the ctable from bcolz and subclass it, so the groupby can then be an extension there? should not be much

FrancescElies commented 9 years ago

i think so too

FrancescElies commented 9 years ago

I think still some additional stuff needs to be done, but for the moment I leave it like this

FrancescElies commented 9 years ago

maybe factorize_groupby_cols, make_group_index, create_agg_ctable & where_terms should be moved inside the subclass, what do you think?

FrancescElies commented 9 years ago

Atm it seems to work, but I am sure it needs to be polished and bugs will have to be fixed but I'll merge. Maybe we could also think of using Travis CI like bcolz