visualgitio / LGit

Git porcelain & MSSCCI provider
Other
11 stars 2 forks source link

Subproject stuff #9

Open NattyNarwhal opened 3 years ago

NattyNarwhal commented 3 years ago

The subproject stuff feels really nebulous, but it seems that solution-based VS (devenv), even the '98 versions, wants a notion of this. I'm not sure how it maps to git, except I don't think submodules would fit; I think it's more multiple projects in a solution.

We'll need it at least for AddFromScc support; I believe this is SetOpt 6.

NattyNarwhal commented 3 years ago

The AddFromScc portion is implemented.

NattyNarwhal commented 3 years ago

https://social.msdn.microsoft.com/Forums/security/en-US/42344528-9ad2-4845-a1f5-0a78ca7efbdb/confusion-about-scccreatesubproject-msscci-v12

NattyNarwhal commented 3 years ago

Implication from above is this only seems used for when things are split - like a web project

NattyNarwhal commented 3 years ago

Testing adding a project from another dir already under SCC, VS2005 seems to handle it well.

NattyNarwhal commented 3 years ago

though if i create a proj in the solution outside of the solution root:

The project that you are attempting to add to source control may cause other source control users to have difficulty opening this solution or getting newer versions of it. To avoid this problem, add the project from a location below the binding root (C:\Documents and Settings\Calvin Buckley\My Documents\Visual Studio 2005\Projects\Site3) of the other source controlled projects in the solution.

NattyNarwhal commented 3 years ago

after GetParentProjPath returns:

There was an error trying to create a folder in the source control database using the default name. To continue adding the project to source control you'll have to manually select the desired database location.

NattyNarwhal commented 3 years ago

Yet it calls GetProjPath (which offers to git init). When we disable the subproj caps, it just skips directly to that, which is the right thing.

If the subproject stuff made the web case easier, I think it might be worth justifying. Otherwise, without an example, why?