visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN
https://visualize.admin.ch
BSD 3-Clause "New" or "Revised" License
32 stars 3 forks source link

Implementation: Combining Multiple Cubes (1. Iteration) #1367

Open sosiology opened 9 months ago

sosiology commented 9 months ago

Description Implementation of the UI to enable the merging of data sets in a diagram. This first iteration focuses on merging cubes based on a common temporal dimension. The implementation is based on the design delivered at the end of Sprint 5.5.

Link to Design https://www.figma.com/proto/Hn9wvuEYLUmdJtg4KwZYUx/visualize.admin.ch---design?page-id=904%3A81373&type=design&node-id=3030-242594&viewport=131%2C1040%2C0.08&t=Q4T56Qxo1LTUc7nK-1&scaling=min-zoom&starting-point-node-id=904%3A81378&show-proto-sidebar=1

DoD As a user, I can select a dataset, add another one and create a chart based on the temporal dimension and then publish it.

Assumption/Risks The performance of the editor mode could be reduced due to loading multiple filters.

sosiology commented 8 months ago

@ptbrowne Initial Feedback after initially testing on TEST with the flag ?flag__add-dataset=true

When adding a data set, and there are no matching results, the UI shows "No results" even when searching using the search field, no results are found. I find this confusing, becuase i dont fully understand what I should do. I think we could counter this by having a better message e.g No datasets with shared dimensions found or something similar

Image

When creating a chart with 2 data sets (Bathing Water quality and Heavy Metal Soil Contamination) the chart is not rendered correctily, There is no x-axis label and when hovering near the blue bar a date is shown outside the chart

Image

https://test.visualize.admin.ch/en/v/6RDCv0hC9pWM?dataSource=Prod

KerstinFaye commented 8 months ago

Thanks @ptbrowne. Looks great already. Few little things that I found:

Image

ptbrowne commented 7 months ago

Thanks Kerstin, I put the improvements on two separate issues, smaller things directly in the part 2 of Combining multiple cubes, and the part on the legend that is a bit bigger on a separate issues.