search

visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN
https://visualize.admin.ch
BSD 3-Clause "New" or "Revised" License
30 stars 3 forks source link

fix: PossibleFilters firing when it doesn't make sense #1433

Closed bprusinowski closed 5 months ago

bprusinowski commented 5 months ago

Fixes #1430

This PR prevents the PossibleFilters query from being fired when it doesn't make sense (no filters are present). It also shares some logic related to PossibleFilters query across different parts of the application.

How to test

PR

  1. Go to this link.
  2. ✅ See that there's no error in the Filters section.

TEST

  1. Go to this link.
  2. ❌ See that there's an error in the Filters section.
vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 10:32am
Rdataflow commented 5 months ago

@bprusinowski curious to see this on TEST - deploy didn't pass though. thus asking, can you redeploy this or any later commit?

bprusinowski commented 5 months ago

@Rdataflow it looks like it deployed, maybe it was still in progress when you checked? 🤔 (https://github.com/visualize-admin/visualization-tool/commit/3f461271be6dac22930f85e809e3109296e26f2d is the deployed commit on TEST)

Rdataflow commented 5 months ago

@bprusinowski thank you - I see it's online now 👍