Shared termset search - Githubissues

visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN

https://visualize.admin.ch

BSD 3-Clause "New" or "Revised" License

30 stars 3 forks source link

Shared termset search #1453

Closed ptbrowne closed 4 months ago

ptbrowne commented 4 months ago

The main change of this PR is to change from having a termset centered UI to a dimension centered UI. It should hopefully make the UI more relatable to the users as termsets are not connected to cube but dimensions. To be able to show dimensions with their termsets inside the search results, I switched to a CONSTRUCT query. The storybook is updated, dimensions can be hovered to show the termsets.

[x] Can search by shared termsets
[x] Search query uses construct which makes it powerful (can fetch dimensions, termsets, time units for each cube)
[x] Add dataset dialog shows dimensions and hovering shows termsets
[x] Add dataset dialog has a filter where you can select which dimensions should be considered when searching searchable datasets
[x] Added stories to showcase join by on multiple cubes
[x] Temporal dimensions should be shown as "shared dimension" in search results
[ ] Join by should support multiple dimensions

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
visualization-tool	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 22, 2024 4:19pm

bprusinowski commented 4 months ago

One thing I noticed currently on TEST: we can merge the same cube to the currently selected one, which results in no joinBy dimension error. Just thought I would drop it here, maybe it could be connected to this PR? 🤔

ptbrowne commented 4 months ago

I think Bartosz that you can review this PR as I will tackle the ability to join by several dimensions in another PR. Thanks 🙇 .

ptbrowne commented 4 months ago

One thing I noticed currently on TEST: we can merge the same cube to the currently selected one, which results in no joinBy dimension error. Just thought I would drop it here, maybe it could be connected to this PR? 🤔

No longer possible.

I could remove dimension filters completely and try to add non-compatible cube (e.g. Forest fire danger), which didn't do anything

Added a text when nothing is selected, and paused the query.

Haven't checked the design, but feels like termsets could also be yellow? 🤔

Updated this, the termset tags are gray now.

Looks like the editor filters are not aligned with interactive time range filters (might not be related to this PR), see 2009 in the editor and 2014 in interactive filter 👀

Don't know about that, I will check later.