search

visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN
https://visualize.admin.ch
BSD 3-Clause "New" or "Revised" License
30 stars 3 forks source link

fix: Temporal joinBy dimension X axis filters #1455

Closed bprusinowski closed 4 months ago

bprusinowski commented 4 months ago

This PR fixes a bug discovered by @sosiology that made the temporal X axis filtering not working with cubes merged by a temporal dimension. It also fixes an error of not displaying date pickers for joinBy dimensions.

How to test

PR

  1. Go to this link.
  2. Add a new cube – Heavy Metal Soil Contamination.
  3. Go to horizontal axis.
  4. ✅ See that the date pickers are displayed.
  5. ✅ See that date filtering works.

TEST

  1. Go to this link.
  2. Add a new cube – Heavy Metal Soil Contamination.
  3. Go to horizontal axis.
  4. ❌ See that the date pickers are not displayed.
  5. ❌ See that date filtering doesn't work (jumps back to original selection).
vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 7:03am
sosiology commented 4 months ago

Thanks for adding this @bprusinowski here is a link to the visualization that can be copied to reproduce / test if the issue is resolved: https://test.visualize.admin.ch/v/LCgDy6LkeYmc?dataSource=Test