search

visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN
https://visualize.admin.ch
BSD 3-Clause "New" or "Revised" License
29 stars 3 forks source link

fix: ChartPreview with Tall dashboard layout in edit mode and interactive filters active #1469

Closed bprusinowski closed 3 months ago

bprusinowski commented 3 months ago

Fixes #1468

This PR fixes broken ChartPreview subgrid positioning in Tall dashboard in edit mode when interactive filters were applied in one chart and not in the other. It also shares common styles between ChartPreview and ChartPublished.

How to test

PR

  1. Go to this link.
  2. Select a cube and create a chart.
  3. Add two more charts, so there are three in total.
  4. Enable interactive filter for the third chart.
  5. Proceed to Layout options.
  6. Change Layout to Tall Dashboard layout.
  7. ✅ Scroll down to see that the last chart has correct layout.

TEST

  1. Repeat the above process on TEST.
  2. ❌ Scroll down to see that the last chart has broken layout.
vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 7:01am