Upgrade cube version initially and once only on client-side - Githubissues

visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN

https://visualize.admin.ch

BSD 3-Clause "New" or "Revised" License

29 stars 3 forks source link

Upgrade cube version initially and once only on client-side #1472

Closed bprusinowski closed 2 months ago

bprusinowski commented 3 months ago

Situation

Each GQL query re-initiates the version upgrade on it's own, even after the version information is already known at the client
Version upgrade is not streamlined across all the different GQL queries (i.e. some use LightCube, others won't)

Motivation

Firing less queries to the SPARQL endpoint helps to improve the general performance. Therefore omitting double queries (i.e. for version upgrade) will help to improve.

DoD

[x] The cube version information initially queried by the client is reused - suceeding GQL queries rely on that dynamically queried information, therefore no need to re-query for version upgrades.
[x] The version upgrade functionality is streamlined among all the GQL queries. The recent improved query pattern from getLatestCubeIriQuery is reused therefore.

Rdataflow commented 2 months ago

LGTM 👍