visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN
https://visualize.admin.ch
BSD 3-Clause "New" or "Revised" License
29 stars 3 forks source link

feat: Add logic to merge multiple by multiple join bys #1480

Closed ptbrowne closed 2 months ago

ptbrowne commented 3 months ago

Some cubes should be merged on multiple dimensions. This PR makes it possible.

How to test

  1. Start with Photovoltaikanlagen <PREVIEW_URL>/en/create/new?cube=https://energy.ld.admin.ch/sfoe/bfe_ogd84_einmalverguetung_fuer_photovoltaikanlagen/9&dataSource=Prod
  2. Click add dataset
  3. Median electricity per Kanton is mergeable through "year" and "kanton"
  4. Preview shows the two columns as joined
  5. Ability to switch between map / line charts and other charts
vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 5:28pm
ptbrowne commented 2 months ago

Thanks @bprusinowski, the charts should not look broken anymore (not enough filters applied when switching from chart to chart), and the published chart should not look different anymore (bug of extracting component iris from chart config).