fix: Dimension values unversioning

visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN

https://visualize.admin.ch

BSD 3-Clause "New" or "Revised" License

29 stars 3 forks source link

fix: Dimension values unversioning #1496

Closed bprusinowski closed 2 months ago

bprusinowski commented 2 months ago

Fixes #1497

Fixes regression from https://github.com/visualize-admin/visualization-tool/commit/908ddd71fa593fbb8dab5ae99936ff6eaf76d3a7 (metadata is only attached to versioned values)

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
visualization-tool	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 3, 2024 4:05pm

ptbrowne commented 2 months ago

Just to be sure, it seems like a large number of E2E tests are failing (more than then 4/5 that are flaky), do they pass on your machine ? ~~Do you know if this bug was introduced recently ? Was it during the latest performance improvements ?~~ Do you see a way to add a test so that it does not reproduce ?

EDIT: Removed question on whether the bug was introduced recently, I had missed the commit link in the description.

bprusinowski commented 2 months ago

@ptbrowne not all pass on my machine, also due to problems with LINDAS, so in some cases it's not obvious to narrow down the issue 😨