visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN
https://visualize.admin.ch
BSD 3-Clause "New" or "Revised" License
29 stars 3 forks source link

✅ ✅ Adding Chart from different dataset: Sort by and include draft datasets reset #1537

Closed sosiology closed 1 month ago

sosiology commented 1 month ago

Description when creating a new chart from a new dataset, in the select data set panel the filters for "include draft data sets" and "sort by" are reset when one is selected.

To Reproduce

  1. go to: test.visualize.admin.ch
  2. select any data set to start the chart creation process
  3. Create a chart and then hit the + to add a new chart using another dataset
  4. in the select data set panel click / select "include draft datasets"
  5. Once the draft data sets are shown, select "sort by date" and see that the "include draft datasets" check box is no longer active

https://github.com/visualize-admin/visualization-tool/assets/29289679/081d1602-8080-43d9-bee4-27987330a1ad

Visualize Version: v4.5.1 (6f213e7) Browser: Chrome

sosiology commented 3 weeks ago

LGTM, thanks for the fix @bprusinowski 👏