Accent - Githubissues

visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN

https://visualize.admin.ch

BSD 3-Clause "New" or "Revised" License

29 stars 3 forks source link

Accent #1543

Closed ptbrowne closed 1 month ago

ptbrowne commented 1 month ago

[x] Created project in Accent
[x] Imported translations to Accent
[x] Added config and scripts to push / pull translations to Accent

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
visualization-tool	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 30, 2024 7:23am

wereHamster commented 1 month ago

Accent supports showing comments in the UI (only in gettext files though): https://github.com/mirego/accent/issues/135#issuecomment-1418452432

I was never able to test that, since all my project use JSON and not gettext files. It looks like accent sync does not include any comments in generated .po files (judging by the diff):

ptbrowne commented 1 month ago

Thanks for this, I opened a new issue for Accent so that they preserve the comments when pulling. To circumvent this problem and preserve comments, I now re-run lingui extract after pulling the locales from accent. It seems it does the job well. Now the diff of this PR is much cleaner :)

ptbrowne commented 1 month ago

Internal purposes, I expect that this way it will be easier to share translations with @KerstinFaye