visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN
https://visualize.admin.ch
BSD 3-Clause "New" or "Revised" License
29 stars 3 forks source link

✅ Chart doesn't show up correctly in layout option preview after editing #1547

Closed sosiology closed 1 month ago

sosiology commented 1 month ago

Describe the bug Sometimes charts are not rendered correctly in the layout step, if the user goes back and forth between the layout step and the editing mode.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'test.visualiuze.admin.ch'
  2. Select any data set and create a chart and duplicate it
  3. Proceed to layout options, select Dashboard and Free Canvas and charts are rendered correctly
  4. click the "back to editing" and add a new chart with a different data set
  5. Proceed to layout options and see that the newly added chart is not rendered correctly

image

Expected behavior I would expect to be able to move freely between the layout steps and editor mode, and have charts rendered correctly

Screenshots or video

https://github.com/visualize-admin/visualization-tool/assets/29289679/9352f189-818b-4e30-bb58-0e69f29b55b7

Environment (please complete the following information):

Additional context Add any other context about the problem here.

sosiology commented 3 weeks ago

LGTM, couldn't reproduce. Thanks @bprusinowski