search

visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN
https://visualize.admin.ch
BSD 3-Clause "New" or "Revised" License
31 stars 3 forks source link

✅ Edit saved dashboard - jump to layout options #1550

Closed KerstinFaye closed 3 months ago

KerstinFaye commented 4 months ago

After clicking edit on a saved dashboard in my profile arrive at the edit mode for all charts instead of the layout options step.

  1. Create dashboard
  2. Save dashboard
  3. Click edit on the saved dashboard
  4. I end up in the edit more of all charts instead of the layout options step.

IArriving at the layout options step when revising a dashboard could enhance the comparison and decision-making process for chart revisions.

sosiology commented 4 months ago

Interesting input @KerstinFaye . When i was testing, the login and the feature it made sense to be that if you click on edit from your profile you are taken to the editor mode. But i see your point that for dashboards the layout step would be more intuitive. It would only apply to the Dashboards though, right?

ptbrowne commented 4 months ago

This is more a discussion than an issue at this point correct ? I think we could argue that for a user, always landing on the same view from the same link would make sense ? And we could add another action "Edit layout" only for configs that are in "dashboard" layout ?

sosiology commented 4 months ago

@ptbrowne i think so. Will add it to the internal sync agenda for Tuesday so we can decide on the best approach

sosiology commented 3 months ago

Decision from Team Sync on 06.04.2024: As soon as there is more than one chart config, we default to the layout page

sosiology commented 3 months ago

Tested on TEST with my eiam login, lgtm. Thanks @bprusinowski 🙇‍♀

KerstinFaye commented 3 months ago

Thanks a lot for implementing this. That's great. I would like to change one more thing: I assume it would be confusing for the user that when clicking on the draft title they end up in a published more with the banner that this is still a draft. But there they still have the option to publish and embed even though it is still a draft. I would like to disable the title for a draft. Then the only clear call to action is that they would click on edit to further work on the draft. @ptbrowne @bprusinowski @sosiology What do you think?

sosiology commented 1 month ago

LGMT tested on INT