search

visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN
https://visualize.admin.ch
BSD 3-Clause "New" or "Revised" License
31 stars 3 forks source link

feat: Add temporal entity dimension filtering to dashboard filters #1568

Closed bprusinowski closed 3 months ago

bprusinowski commented 3 months ago

...and fix the time range brush for TemporalEntityDimension in column charts.

Closes #1555

How to test

Time brush for temporal entity dimension based X axis

PR

  1. Go to this link.
  2. Open Horizontal Axis settings.
  3. Enable interactive filter.
  4. ✅ See that it's possible to filter the chart.

TEST

  1. Go to this link.
  2. Open Horizontal Axis settings.
  3. Enable interactive filter.
  4. ❌ See that it's not possible to filter the chart (NaN values displayed in the brush).

Temporal entity dimension in shared dashboard filters

PR

  1. Go to this link.
  2. Add another chart (e.g. line).
  3. Proceed to layout options.
  4. Switch to a dashboard layout.
  5. Enable shared Date filter.
  6. Filter the chart using the time brush.
  7. ✅ See that both charts are filtered as expected.

TEST

  1. Go to this link.
  2. Add another chart (e.g. line).
  3. Proceed to layout options.
  4. Switch to a dashboard layout.
  5. ❌ See that it's not possible to enable shared Date filter.
vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 3:51pm
ptbrowne commented 3 months ago

I think we could remove the Slider ticks when there are more than 50 ?

image