fix: Full data download (merged cubes)

visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN

https://visualize.admin.ch

BSD 3-Clause "New" or "Revised" License

31 stars 3 forks source link

fix: Full data download (merged cubes) #1571

Closed bprusinowski closed 3 months ago

bprusinowski commented 3 months ago

Fixes #1536

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
visualization-tool	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 7, 2024 0:21am

ptbrowne commented 3 months ago

I do not understand what's happening here ? Do we a joinBy iri inside dataCubeMetadata.iri in case of merged cubes ?

bprusinowski commented 3 months ago

Currently, we pass queryFilters which is an array in case of having merged cubes. As full data download is scoped per given dataset, we need to pass correct query filters (per given cube) 👍

bprusinowski commented 3 months ago

I refactored to make it clear from the code 👍