feat: Activate shared filters for "tab" layout

visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN

https://visualize.admin.ch

BSD 3-Clause "New" or "Revised" License

29 stars 3 forks source link

feat: Activate shared filters for "tab" layout #1586

Closed ptbrowne closed 3 weeks ago

ptbrowne commented 3 weeks ago

Activate dashboard filters for tab layout

[x] In configurator mode
[x] In published mode

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
visualization-tool	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 11, 2024 0:45am

bprusinowski commented 3 weeks ago

Ah, I see that it's in fact persisted, it's just the slider that's initialized with the full range on switch 🤔

bprusinowski commented 3 weeks ago

On a side note: I wonder if we shouldn't disable enter animations for charts (only for the initial render, filtering elements out or time-based animations should still persist this logic) – currently it's quite bad for a column chart (falls down from the top). This would also make it easier to compare the changes when switching thought the tabs, what do you think? The update animations could stay :)

ptbrowne commented 3 weeks ago

I'll take a look, thanks.