search

visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN
https://visualize.admin.ch
BSD 3-Clause "New" or "Revised" License
29 stars 3 forks source link

✅ ✅ Tabs have labels #1587

Closed ptbrowne closed 3 weeks ago

ptbrowne commented 3 weeks ago

After feedback from Matthias Brändli, we decided that tabs should have labels. The label is the title of the chart. The behavior of the width of the tabs should mimick browser tabs.

ptbrowne commented 3 weeks ago

Was fixed in https://github.com/visualize-admin/visualization-tool/pull/1584

KerstinFaye commented 3 weeks ago

Thank you @sosiology. I didn't see this. I'll delete the other one. @ptbrowne Not sure yet, how we handle multiple languages? Only the on that the editor wrote I assume? That would work I think. I wonder what happens if the editor does not give a chart title? I would avoid having a "no title" box in the published version in case the editor doesn't give a chart title. This is at the moment in the implemented version the case. I would suggest that in case of no title is given it also wont show in the published version. (like the chart title)

sosiology commented 3 weeks ago

@KerstinFaye seems like the translations and charts not having a title are already accounted for see examples below

Chart with labels in all languages: https://test.visualize.admin.ch/en/v/W6-T_gW3_6y3?dataSource=Prod Chart with label only in EN: https://test.visualize.admin.ch/en/v/IkmUw2wTEwo9?dataSource=Prod

👏 thanks @ptbrowne

KerstinFaye commented 2 weeks ago

Thanks a lot. Looks good.