search

visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN
https://visualize.admin.ch
BSD 3-Clause "New" or "Revised" License
29 stars 3 forks source link

Fix: cube query filters not found #1614

Closed ptbrowne closed 2 weeks ago

ptbrowne commented 2 weeks ago

In https://github.com/visualize-admin/visualization-tool/pull/1571, we introduce the use of cube query filters, but this does not play well with tab layout when components are reused.

Some of the data hooks were reused, introducing a mismatch between what was fetched inside the hooks and the new chartConfig.

To force remounting, I used a key on ChartPublishedInner and made it so that we cannot forget it.

This fixes going to the second chart of https://test.visualize.admin.ch/en/v/FeByTTGfNhxL

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 1:00pm