search

visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN
https://visualize.admin.ch
BSD 3-Clause "New" or "Revised" License
29 stars 3 forks source link

feat: Minimum chart height in a dashboard #1647

Closed bprusinowski closed 1 week ago

bprusinowski commented 1 week ago

Closes #1637

How to test

PR

  1. Go to this link.
  2. Add a super-long title for the chart, e.g. Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
  3. Add a new pie chart.
  4. Add the same long title to the chart.
  5. Add a new map chart.
  6. Add a new scatterplot chart.
  7. Proceed to layout options.
  8. Switch layout to dashboard / free canvas.
  9. ✅ See that the charts initialized in min-height mode and the cards have dynamic heights based on the content.
  10. ✅ Try to resize the cards vertically and see that they are constrained in a way that you can't make the chart invisible or the content overflowing.

TEST

  1. Go to this link.
  2. Add a super-long title for the chart, e.g. Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
  3. Add a new pie chart.
  4. Add the same long title to the chart.
  5. Add a new map chart.
  6. Add a new scatterplot chart.
  7. Proceed to layout options.
  8. Switch layout to dashboard / free canvas.
  9. ❌ See that the charts initialized with the same, hard-coded height, and some of them and not visible or broken.
  10. ❌ Try to resize the cards vertically and see that they are not constrained and you can make the chart invisible or the content overflowing.
vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 0:01am