search

visualize-admin / visualization-tool

The tool for visualizing Swiss Open Government Data. Project ownership: Federal Office for the Environment FOEN
https://visualize.admin.ch
BSD 3-Clause "New" or "Revised" License
30 stars 3 forks source link

inconsistent dataset count on termset filter #1704

Open Rdataflow opened 2 weeks ago

Rdataflow commented 2 weeks ago

While the cube count having termset Kantone LFI is shown as 33 the actual filter shows 0 such cubes.

To Reproduce Steps to reproduce the behavior:

  1. Open https://test.visualize.admin.ch/browse/termset/https%3A%2F%2Fld.admin.ch%2Fdimension%2Fbgdi%2Fbiota%2Fcantonregions?topic=&dataSource=Int
  2. see emty result set
  3. compare to the 33 results for "Kantone LFI" at https://test.[visualize.admin.ch](https://test.visualize.admin.ch/browse?topic=&dataSource=Int)/browse?topic=&dataSource=Int

Expected behavior Consistent count of cubes

Screenshots or video image vs image

Environment (please complete the following information):

Additional context see https://github.com/visualize-admin/visualization-tool/blob/99eb19f12af6920f27d9b7475e6ff74b6501ab98/app/rdf/query-search.ts#L233 there is a remaining sh:in/rdf:first which needs also to be ported to the new triples

cc @bprusinowski

Rdataflow commented 2 weeks ago

With the new triples the query performs fast and it would even make sense to combine the SearchPage into SearchCubes in order to deduplicate - WDYT?

bprusinowski commented 2 weeks ago

Hi @Rdataflow, thanks for reporting the bug. I think it would make sense to combine the two queries, thanks for this suggestion, I'll take a look in the coming days :)